[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 885c512: Fix a bug in 'generate-new-buffer-name
From: |
Stefan Monnier |
Subject: |
Re: [Emacs-diffs] master 885c512: Fix a bug in 'generate-new-buffer-name' |
Date: |
Sat, 05 Aug 2017 11:14:30 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
>> > - if (!NILP (Fstring_equal (name, ignore)) || NILP (Fget_buffer (name)))
>> > + if ((!NILP (ignore) && !NILP (Fstring_equal (name, ignore)))
>> > + || NILP (Fget_buffer (name)))
>> Why not just use Fequal instead of Fstring_equal?
> Because no one said that using a symbol for the IGNORE argument is
> forbidden in that function. "nil" just happens to be a special case,
> but other strings/symbols are allowed.
I'd be surprised if there is code out there that uses a symbol for the
`ignore` argument. And I don't think it's a feature that you can use
a symbol rather than a string. I think it's rather a (harmless (except
for nil)) bug.
Stefan