[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Slightly extending commit 16b0520a9
|
From: |
Stefan Monnier |
|
Subject: |
Re: Slightly extending commit 16b0520a9 |
|
Date: |
Sun, 06 Aug 2017 00:08:25 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
> cond = eval_sub (XCAR (args));
>
> if (!NILP (cond))
> - return eval_sub (Fcar (XCDR (args)));
> + return eval_sub (XCAR (XCDR (args)));
I don't see anything in the preceding code that guarantees that `XCDR (args)`
holds a cons, so I think XCAR here is unsafe.
> @@ -806,7 +806,7 @@ usage: (defconst SYMBOL INITVALUE [DOCSTRING]) */)
> if (CONSP (Fcdr (XCDR (XCDR (args)))))
> error ("Too many arguments");
>
> - tem = eval_sub (Fcar (XCDR (args)));
> + tem = eval_sub (XCAR (XCDR (args)));
This one looks right, yes,
Stefan