Re: [Emacs-diffs] master 690512d: Fix a FIXME with an exegetical comment

[Reuben Thomas]

On 25 August 2017 at 22:02, Stefan Monnier <address@hidden> wrote:
>>      (wksh sh-append ksh88
>> -          ;; FIXME: This looks too much like a regexp.  --Stef
>> +          ;; wksh has X toolkit APIs as built-ins!
>>         "Xt[A-Z][A-Za-z]*")
>
> But AFAICT sh-builtins is passed to `regexp-opt', so the above will
> simply treat the command with name "Xt[A-Z][A-Za-z]*" as a builtin,
> instead of recognizing any command that matches this regexp.

I'm sorry, I misunderstood what regexp-opt does; I should have looked it up.

Since wksh is as far as I can tell a historical curiosity, the
simplest thing would be to remove the setting for it. Does that seem
reasonable?

-- 
https://rrt.sc3d.org