emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

OK to put lisp/progmodes/flymake.el in ELPA as a :core package?


From: João Távora
Subject: OK to put lisp/progmodes/flymake.el in ELPA as a :core package?
Date: Mon, 03 Dec 2018 12:08:35 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt)

Hi,

The subject should summarize my question.  I've done some work in
flymake.el (bugfixes and some new features) that shouldn't have to wait
for Emacs 27, so I think this is a nice way for users in Emacs
26.1 and upcoming 26.2 to see those changes.

The only thing that's slightly putting me off is flymake.el's
requirement of lisp/progmodes/flymake-proc.el _after_ the `provide`
statement.  It's odd, but shouldn't be a problem, right?  I can also
remove it but that would break out-of-the-box compatibility with "old"
flymake.

So, if no-one opposes I will be commiting this in the near future:

    Date:   Mon Dec 3 11:58:59 2018 +0000
     
        * externals-list ("flymake"): Add new :core package.
     
    diff --git a/externals-list b/externals-list
    index 6f7d623f7..146a33baf 100644
    --- a/externals-list
    +++ b/externals-list
    @@ -76,6 +76,7 @@
      ("ergoemacs-mode" :external 
"https://github.com/ergoemacs/ergoemacs-mode.git";)
      ("exwm"           :external "https://github.com/ch11ng/exwm.git";)
      ("f90-interface-browser" :subtree "https://github.com/wence-/f90-iface";)
    + ("flymake"                :core "lisp/progmodes/flymake.el")
      ("fountain-mode"  :external "https://github.com/rnkn/fountain-mode";)
      ("ggtags"         :subtree "https://github.com/leoliu/ggtags";)
      ("gnome-c-style"  :subtree "https://github.com/ueno/gnome-c-style.git";)

and also

    Date:   Mon Dec 3 11:52:38 2018 +0000
     
        Prepare flymake.el for distribution in ELPA
        
        * lisp/progmodes/flymake.el: Add Package-Requires.  Bump version to
          1.0.1
     
    diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
    index 5352cc3fe6..ada8d27911 100644
    --- a/lisp/progmodes/flymake.el
    +++ b/lisp/progmodes/flymake.el
    @@ -4,7 +4,8 @@
     
     ;; Author:  Pavel Kobyakov <address@hidden>
     ;; Maintainer: João Távora <address@hidden>
    -;; Version: 1.0
    +;; Package-Requires: ((emacs "26.1"))
    +;; Version: 1.0.1
     ;; Keywords: c languages tools
     
     ;; This file is part of GNU Emacs.


João



reply via email to

[Prev in Thread] Current Thread [Next in Thread]