Re: open-{gnutls,network}-stream backwards compatibility

[Robert Pluim]

Eli Zaretskii <address@hidden> writes:

>> From: Robert Pluim <address@hidden>
>> Cc: address@hidden
>> Date: Fri, 04 Jan 2019 23:29:17 +0100
>> 
>> (defcustom network-stream-use-client-certificates
>> "Whether to use client certificates for network connections.
>> 
>> If set to the default value t, `open-network-stream' will
>> automatically look for matching client certificates (via
>> 'auth-source') for a destination server, but only if it is called
>> without a :client-certificate keyword.
>
> That "only if" is inaccurate, right?  In particular, using non-nil
> :client-certificate attribute will still use client certificates as
> directed, right?
>

True. How about:

   .  It will not override any caller-supplied :client-certificate
   specification.


>> Set to nil to disable this lookup globally.  To disable on a
>> per-connection basis specify ':client-certificate nil' when
>> calling `open-network-stream'.
>
> Sounds OK to me, provided we announce this in NEWS.

Nah, we'll spring it on the users unannounced and see what happens :-)

>
>> (Now to find which custom group this goes in...)
>
> You could make a new group, say, 'network'.

'network' already exists, but itʼs only got one member. Iʼll put it
there.

Robert