[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Require full GMP for big integer module functions.
From: |
Philipp Stephani |
Subject: |
Re: [PATCH] Require full GMP for big integer module functions. |
Date: |
Sun, 28 Apr 2019 20:14:18 +0200 |
Am Do., 25. Apr. 2019 um 23:00 Uhr schrieb Paul Eggert <address@hidden>:
>
> On 4/25/19 10:09 AM, Philipp Stephani wrote:
> > This allows mini-gmp to not stay binary-compatible with full GMP.
>
> Isn't this overkill? I can see many practical scenarios where using
> extract_big_integer etc. will work just fine even if Emacs is compiled
> with mini-gmp and the module with full GMP (or vice versa). I can't see
> many practical scenarios where these additional checks will cause more
> good than harm.
The problem with binary compatibility is that if emacs-mini-gmp.h ever
becomes incompatible, the behavior will silently become undefined,
leading to extremely subtle bugs. So even a bit of harm here is too
much.
>
> Would it help to write to the GMP maintainer and ask how compatible
> mini-gmp is intended to be? My impression is that compatiblity concerns
> are pretty high on his priority list.
For full GMP definitely. My understanding is that emacs-mini-gmp.h is
maintained as part of Emacs, so *we* need to make sure to never become
incompatible if we want to continue to support this use case.
- Re: [PATCH 2/2] Add module functions to convert from and to big integers., (continued)
- Re: [PATCH 2/2] Add module functions to convert from and to big integers., Philipp Stephani, 2019/04/25
- [PATCH 1/2] Require full GMP when building module support., Philipp Stephani, 2019/04/25
- [PATCH 2/2] Check for __attribute__ ((cleanup)) during configuration., Philipp Stephani, 2019/04/25
- Re: [PATCH 2/2] Check for __attribute__ ((cleanup)) during configuration., Paul Eggert, 2019/04/25
- Re: [PATCH 2/2] Check for __attribute__ ((cleanup)) during configuration., Philipp Stephani, 2019/04/28
- Re: [PATCH 1/2] Require full GMP when building module support., Eli Zaretskii, 2019/04/25
- Re: [PATCH 1/2] Require full GMP when building module support., Philipp Stephani, 2019/04/25
- Re: [PATCH 1/2] Require full GMP when building module support., Eli Zaretskii, 2019/04/25
- [PATCH] Require full GMP for big integer module functions., Philipp Stephani, 2019/04/25
- Re: [PATCH] Require full GMP for big integer module functions., Paul Eggert, 2019/04/25
- Re: [PATCH] Require full GMP for big integer module functions.,
Philipp Stephani <=
- Re: [PATCH] Require full GMP for big integer module functions., Paul Eggert, 2019/04/28
- Re: [PATCH 1/2] Require full GMP when building module support., Philipp Stephani, 2019/04/28