[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master d68ed15: Implement and document XDG-style start
From: |
Eli Zaretskii |
Subject: |
Re: [Emacs-diffs] master d68ed15: Implement and document XDG-style startup files under ~/.config. |
Date: |
Mon, 03 Jun 2019 05:32:43 +0300 |
> From: Stefan Monnier <address@hidden>
> Date: Sun, 26 May 2019 18:40:10 -0400
> Cc: "Eric S. Raymond" <address@hidden>
>
> > -;;; startup.el --- process Emacs shell arguments -*- lexical-binding: t
> > -*-
> > +;; startup.el --- process Emacs shell arguments -*- lexical-binding: t -*-
>
> This is an error, it should be 3 semi-colons.
>
> > +(defun find-init-path (fn)
> > + "Look in ~/.config/FOO or ~/.FOO for the dotfile or dot directory FOO.
> > +It is expected that the output will undergo ~ expansion. Implements the
> > +XDG convention for dotfiles."
> > + (let* ((xdg-path (concat "~" init-file-user "/.config/" fn))
> > + (oldstyle-path (concat "~" init-file-user "/." fn))
> > + (found-path (if (file-exists-p xdg-path) xdg-path oldstyle-path)))
> > + found-path))
>
> AFAICT this is only used during startup and hence shouldn't have such
> an "official sounding" name. It could/should use a "startup--" prefix,
> for example.
>
> Furthermore it shouldn't say "path" but "filename" to follow our
> naming convention.
No response in a week.
Would someone like to suggest changes to fix the problems in this
commit? If so, please show the proposed changes, and let's discuss
them. Failing that, I will revert that commit in a couple of days.
- Re: [Emacs-diffs] master d68ed15: Implement and document XDG-style startup files under ~/.config.,
Eli Zaretskii <=
- [PATCH] Implement XDG Base Directory specification for user-emacs-directory (was: [Emacs-diffs] master d68ed15: Implement and document XDG-style startup files under ~/.config.), Amin Bandali, 2019/06/09
- Re: [PATCH] Implement XDG Base Directory specification for user-emacs-directory (was: [Emacs-diffs] master d68ed15: Implement and document XDG-style startup files under ~/.config.), Eli Zaretskii, 2019/06/09
- Re: [PATCH] Implement XDG Base Directory specification for user-emacs-directory, Stefan Monnier, 2019/06/09
- Re: [PATCH] Implement XDG Base Directory specification for user-emacs-directory, Eli Zaretskii, 2019/06/09
- Re: [PATCH] Implement XDG Base Directory specification for user-emacs-directory, Noam Postavsky, 2019/06/09
- Re: [PATCH] Implement XDG Base Directory specification for user-emacs-directory, Eli Zaretskii, 2019/06/10
- Re: [PATCH] Implement XDG Base Directory specification for user-emacs-directory, Noam Postavsky, 2019/06/10
- Re: [PATCH] Implement XDG Base Directory specification for user-emacs-directory, Lars Ingebrigtsen, 2019/06/10
- Re: [PATCH] Implement XDG Base Directory specification for user-emacs-directory, Eli Zaretskii, 2019/06/10
Re: [PATCH] Implement XDG Base Directory specification for user-emacs-directory (was: [Emacs-diffs] master d68ed15: Implement and document XDG-style startup files under ~/.config.), Stefan Kangas, 2019/06/13