[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 74a5a33: Support native image transforms on MS-
|
From: |
Eli Zaretskii |
|
Subject: |
Re: [Emacs-diffs] master 74a5a33: Support native image transforms on MS-Windows |
|
Date: |
Sun, 30 Jun 2019 17:21:58 +0300 |
> Cc: address@hidden, address@hidden
> From: Paul Eggert <address@hidden>
> Date: Sat, 29 Jun 2019 21:08:46 -0700
>
> Eli Zaretskii wrote:
> > divide_double part obfuscates the code for no good reason.
>
> I'm sure we can clear it up. It replaces the check against FLT_MIN, which to
> my
> mind was even more obscure as there are no 'float' values in sight.
I mean that an explicit division together with a test is more clear
than a call to a function that one needs to look up.
> What is the failure scenario here? Is it not floating-point division by zero?
Yes. But in one of the branches that is extremely unlikely, since the
denominator comes from the size of an image that we loaded.