emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Falling to build


From: Eli Zaretskii
Subject: Re: Falling to build
Date: Wed, 01 Jan 2020 19:22:38 +0200

> Date: Wed,  1 Jan 2020 16:34:05 +0000
> From: John <address@hidden>
> 
> This morning all OK in building on openSuSe x86_64 until this happens
> 
>   CC       xfns.o
> xfns.c: In function ‘Fx_display_monitor_attributes_list’:
> xfns.c:5072:30: warning: implicit declaration of function 
> ‘x_get_net_workarea’; did you mean ‘x_set_undecorated’? 
> [-Wimplicit-function-declaration]
>   if (i == primary_monitor && x_get_net_workarea (dpyinfo, &workarea_r))
>                               ^~~~~~~~~~~~~~~~~~
>                               x_set_undecorated
> xfns.c:5072:30: warning: nested extern declaration of ‘x_get_net_workarea’ 
> [-Wnested-externs]

Does the patch below fix this?

diff --git a/src/xfns.c b/src/xfns.c
index b94666d..d0d5d39 100644
--- a/src/xfns.c
+++ b/src/xfns.c
@@ -4572,7 +4572,7 @@ DEFUN ("x-display-save-under", Fx_display_save_under,
     return Qnil;
 }
 
-#ifndef USE_GTK
+#if !defined USE_GTK || !defined HAVE_GTK3
 
 /* Store the geometry of the workarea on display DPYINFO into *RECT.
    Return false if and only if the workarea information cannot be



reply via email to

[Prev in Thread] Current Thread [Next in Thread]