[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 724af76 2/2: Fix sxhash-equal on bytecodes, markers, etc.
From: |
Pip Cet |
Subject: |
Re: master 724af76 2/2: Fix sxhash-equal on bytecodes, markers, etc. |
Date: |
Tue, 7 Jan 2020 19:36:23 +0000 |
On Tue, Jan 7, 2020 at 7:29 PM Paul Eggert <address@hidden> wrote:
> + else if (pvec_type == PVEC_MARKER)
> + {
> + ptrdiff_t bytepos
> + = XMARKER (obj)->buffer ? XMARKER (obj)->bytepos : 0;
> + hash = sxhash_combine ((intptr_t) XMARKER (obj)->buffer, bytepos);
> + hash = SXHASH_REDUCE (hash);
> + }
Again, I don't think there's any reason for using markers as keys in
an equal-based hash table. But if you do, what you probably meant was
to use an eq-based hash table, and that used to work; now it doesn't.
(puthash marker value ht)
<...move marker...>
(gethash marker ht)
won't work.
- Re: master 724af76 2/2: Fix sxhash-equal on bytecodes, markers, etc.,
Pip Cet <=