Re: master 724af76 2/2: Fix sxhash-equal on bytecodes, markers, etc.

[Paul Eggert]

On 1/7/20 11:36 AM, Pip Cet wrote:

> I don't think there's any reason for using markers as keys in
> an equal-based hash table. But if you do, what you probably meant was
> to use an eq-based hash table, and that used to work; now it doesn't.
>
> (puthash marker value ht)
> <...move marker...>
> (gethash marker ht)
>
> won't work.

In what sense doesn't it work? The following code still works, anyway:

  (with-temp-buffer
    (insert "a")
    (let ((marker (point-marker))
          (ht (make-hash-table :test 'eq))
          (value 27))
      (puthash marker value ht)
      (set-marker marker 0)
      (gethash marker ht)))

It's true that if we change 'eq to 'equal in this example, gethash now 
returns nil where it used to return t. But that's the same thing that 
would happen if one modifies a string key in a equal-based hash table. 
So I don't see the problem.