[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-27 3bce7ec: CC Mode: Protect against consecutive calls to befo
|
From: |
Alan Mackenzie |
|
Subject: |
Re: emacs-27 3bce7ec: CC Mode: Protect against consecutive calls to before-change-functions ... |
|
Date: |
Wed, 4 Mar 2020 21:30:14 +0000 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Hello, Mattias.
On Sun, Mar 01, 2020 at 12:49:39 +0100, Mattias Engdegård wrote:
> 28 feb. 2020 kl. 17.54 skrev Glenn Morris <address@hidden>:
> >> CC Mode: Protect against consecutive calls to
> >> before-change-functions ...
> > This causes srecode-utest-getset-output in
> > test/lisp/cedet/srecode-utest-getset.el to fail:
> Indeed, and so does electric-tests. Condensed reproduction:
> (with-temp-buffer
> (c-mode)
> (insert "a")
> (comment-region (point-min) (point-max)))
Actually, your scenario and Glenn's were caused by different bugs. ;-)
> Alan, it looks like the code has lost control over c-new-END.
Yes.
> c-after-change over-adjusts it to a value beyond the buffer size. The
> problem seems to go away with the expedient below but it is unlikely
> to be the right solution.
It wasn't. ;-) I've fixed both bugs in the emacs-27 branch.
--
Alan Mackenzie (Nuremberg, Germany).