Re: [PATCH] src/pgtkfns.c: Do not show an empty frame prematurely

[Yuuki Harano]

On Mon, 14 Jun 2021 08:39:51 +0200,
        Jindřich Makovička <makovick@gmail.com> wrote:
>> Applied, thanks.
>> 
> 
> I see the patch being reverted immediately - did it break anything?

I'm sorry, I should have told you what was broken.

emacs -Q --eval "(scroll-bar-mode -1)" --eval "(menu-bar-mode -1)" --eval 
"(tool-bar-mode -1)" --eval "(make-frame-command)"

This command created an empty frame.
It is reported here:
  https://github.com/masm11/emacs/issues/105

I debugged a bit but I couldn't solve it, so I reverted the patch.

I'm going to debug with the patch.


On Mon, 14 Jun 2021 10:29:41 +0200,
        martin rudalics <rudalics@gmx.at> wrote:
>> I see the patch being reverted immediately - did it break anything?
> 
> And if it broke anything, please explain somewhere in the code what it
> broke.  This should avoid that people apply this or a similar patch in
> the future.

OK, I'll explain the reason in the commit message of the revert commit
next time.

-- 
Yuuki Harano