Re: Native compiler - passing command line options to C compiler

[Arthur Miller]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Arthur Miller <arthur.miller@live.com>
>> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
>> Date: Tue, 31 Aug 2021 07:36:47 +0200
>> 
>> Ok, I have made those changes. I have removed double checks from both
>> add_driver_options () and  add_compiler_options (). If it is not OK, I can 
>> made
>> another one and revert back this change in add_driver_options.
>
> I think you should indeed do the latter.
>
>> I forgott to ask, which Changelog are we talking about? Changelo.3 in top 
>> Emacs
>> dir or some other file?
>
> No file.  We no longer maintain ChangeLog files by hand, we generate
> them from Git log.  So you should include in the patch the log message
> formatted according to ChangeLog rules, but not a patch to any
> specific ChangeLog file.

Oki, guys here is one: no Windows check, but double checks left. That is what is
asked? Hopefully changelog works, I have tried to conform to instruction in
CONTRIBUTING and I have tried to keep mysef breef.

I forgott to say, I have tested to sett options via Customize and it worked
fine, so I have also removed that 'FIXME' in comp.el next to '(repeat string)
option. Hope it is  OK.

Since this is a user visible change, does it need to be documented in some
manual and NEWS too?

Best regards
/arthur

ncomp-options.patch
Description: Text Data