emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 90744ff0be 1/2: comint-fl: Prevent fontification of output as


From: miha
Subject: Re: master 90744ff0be 1/2: comint-fl: Prevent fontification of output as input
Date: Thu, 06 Oct 2022 20:31:18 +0200

Eli Zaretskii <eliz@gnu.org> writes:

>> branch: master
>> commit 90744ff0be581b69cedea1194b7e78265bdb67a4
>> Author: Miha Rihtaršič <miha@kamnitnik.top>
>> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>> 
>>     comint-fl: Prevent fontification of output as input
>>     
>>     * lisp/comint.el (comint-output-filter): Inhibit jit-lock
>>     fontification of inserted process output before marking it with the
>>     'output' filed property (bug#58169).
>> ---
>>  lisp/comint.el | 24 +++++++++++++-----------
>>  1 file changed, 13 insertions(+), 11 deletions(-)
>> 
>> diff --git a/lisp/comint.el b/lisp/comint.el
>> index e7d2136c84..15c9388ea4 100644
>> --- a/lisp/comint.el
>> +++ b/lisp/comint.el
>> @@ -2150,24 +2150,26 @@ Make backspaces delete the previous character."
>>          ;; insert-before-markers is a bad thing. XXX
>>          ;; Luckily we don't have to use it any more, we use
>>          ;; window-point-insertion-type instead.
>> -        (insert string)
>> +        (make-local-variable 'jit-lock-mode)
>> +        (let ((jit-lock-mode nil))  <<<<<<<<<<<<<<<<<<<<<<<<<<<<
>> +          (insert string)
>
> Isn't that hammer too large/blunt for this job?  It will disable every
> single function registered with jit-lock, not just the fontification
> functions.  Some of the functions registered with jit-lock have
> nothing to do with fontifications.

Sorry for late reply. I agree. Please consider applying the attached
patches.

See also reply https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58169#31

Attachment: 0001-Revert-comint-fl-Prevent-fontification-of-output-as-.patch
Description: Text Data

Attachment: 0002-comint-fontify-input-Don-t-fontify-output-as-input-d.patch
Description: Text Data

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]