emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Call for volunteers: add tree-sitter support to major modes


From: Theodor Thornhill
Subject: Re: Call for volunteers: add tree-sitter support to major modes
Date: Mon, 10 Oct 2022 08:35:21 +0200

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Yuan Fu <casouri@gmail.com>
>> Date: Sun, 9 Oct 2022 21:05:09 -0700
>> Cc: Eli Zaretskii <eliz@gnu.org>,
>>  emacs-devel@gnu.org
>> 
>> > +
>> > +(defun js--treesit-enable ()
>> > +  (unless (and (treesit-can-enable-p)
>> > +               (treesit-language-available-p 'javascript))
>> > +    (error "Tree sitter isn't available"))
>> > 
>> > I don't think we should error here, I'd displaying a message instead.
>> 
>> Actually we should also fall back to non-tree-sitter if the conditions 
>> aren’t met.
>
> Automatically and silently?  I don't think so.  The user should know
> the knob they pressed didn't work.

How about we error and add a suggestion to turn off `*-use-treesitter'?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]