emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expre


From: Po Lu
Subject: Re: feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible.
Date: Fri, 14 Oct 2022 20:10:02 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux)

Vibhav Pant <vibhavp@gmail.com> writes:

> branch: feature/comp-use-ctors
> commit 1b48e8dde5bfee65c036fbfdc32b68c9093c2e06
> Author: Vibhav Pant <vibhavp@gmail.com>
> Commit: Vibhav Pant <vibhavp@gmail.com>
>
>     src/comp.c: Use constructor expressions when possible.
>     
>     * src/comp.c:
>       - Add declarations for creating constructor/initializer expressions
>       when supported.
>       - (emit_coerce): Use a struct constructor expression to create a
>       Lisp_Object value instead of creating a new local variable.
>       - emit_limple_call_ref: Emit a single constructor expression for
>       initializing tmp_arr.

This is not how we write commit messages; it should be:

* src/comp.c: Add declarations for creating
constructor/initializer expressions when supported.
(emit_coerce): Use a struct constructor expression to create a
Lisp_Object value instead of creating a new local variable.
(emit_limple_call_ref): Emit a single constructor expression for
initializing tmp_arr.

Keep in mind that the commit message must also be filled to 64 columns.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]