emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Obsolete variable in cc-defs.el


From: Stefan Monnier
Subject: Re: Obsolete variable in cc-defs.el
Date: Mon, 17 Oct 2022 17:54:12 -0400
User-agent: Gnus/5.13 (Gnus v5.13)

> That is a mistake in declaring inhibit-point-motion-hooks obsolete.  As
> long as the properties point_entered and point_left exist and work
> (regardless of whether they are declared obsolete),
> inhibit-point-motion-hooks is required.  It's use shouldn't (yet)
> generate any warnings.

You don't need to let-bind it to t in Emacs≥25 because its default value
is already t.  So for Emacs≥25 you should simply remove that let-binding.

> It's obsolesence message is also suboptimal.

Indeed: it is meant for the case where you set or let-bind that variable
to nil rather than when you set/bind it to t.

> That role will be fulfilled by the variable cursor-sensor-inhibit,
> which really ought to be in c-save-buffer-state (in cc-defs.el)
> alongside i-p-m-h.

You don't need it there and let-binding it there would have no effect at
all unless the body of `c-save-buffer-state` does things like run
a recursive-edit or pause for redisplay (that var is only consulted
"outside", e.g. from `post/pre-command-hook` or
`pre-redisplay-functions`).


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]