Re: vc-find-revision-no-save?

[Philip Kaludercic]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Philip Kaludercic [2022-10-29 06:46:00] wrote:
>> Richard Stallman <rms@gnu.org> writes:
>>> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
>>> [[[ whether defending the US Constitution against all enemies,     ]]]
>>> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
>>>
>>>   > I can answer this one: because back when we wrote this code, the "Git"
>>>   > of the day was called "CVS" and getting a historic revision required
>>>   > fetching it from the centralized server, so you were usually quite happy
>>>   > to keep a local copy, even if you had to erase them manually every once
>>>   > in a while.
>>>
>>> I still sometimes use CVS, and this feature is still useful with it.
>>
>> In that case the suggestion to change the behaviour depending on the VCS
>> should be fine.  If a VCS requires a network connection, storing the
>> files locally can be helpful.
>
> Note that, IIRC, the way the code works, if `vc-find-revision-no-save`
> is non-nil you get an unsaved "file buffer", so it just takes a `C-x
> C-s` to write the file to its "usual" place (i.e. `FILENAME.~REV~`,
> IIRC) if you think it's worthwhile.
>
> For that reason, I'm not convinced we need a special per-VCS handling
> of this.

Right, I didn't think of that.

I am just wondering if there are people who would rely on the previous
behaviour and would be surprised if this were to change all of a sudden?

>
>         Stefan