Re: [PATCH] em-cmpl: fix completion of command paths

[Jim Porter]

Hi Nicolas,

On 1/7/2023 4:19 AM, Nicolas Martyanoff wrote:
> Completion was originally broken by 82c76e3.
>
> The use of `completion-table-dynamic' was introduced in 899055e to fix
> bug#48995. However the following issue remains: when completing a command
> path, absolute ("/usr/bin/") or relative ("./subdir/"), a space is
> automatically added at the end.

Thanks for this patch. I'm looking to add a regression test for this so 
that it doesn't crop up again sometime in the future. However, I can't 
seem to cause completion to fail as you describe, so it's hard to write 
the test. I tried reverting your patch on the emacs-29 branch and then 
running:

emacs -Q -f eshell

;; Within Eshell, enter:
/usr/bi<TAB>

This completes to "/usr/bin/|", where "|" is the point. However, that's 
the correct behavior as far as I understand it, so I must be missing 
something. Do you have more complete steps to reproduce this?