Re: emacs-29 cd05fca5f78: ; Improve documentation of 'native-comp-enable-subr-trampolines'

[Theodor Thornhill]

On 21 February 2023 04:29:48 CET, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Mon, 20 Feb 2023 23:08:11 +0100
>> From: Theodor Thornhill <theo@thornhill.no>
>> CC: Eli Zaretskii <eliz@gnu.org>
>> 
>> 
>> 
>> On 20 February 2023 22:19:31 CET, "Daniel Martín" <mardani29@yahoo.es> wrote:
>> >Eli Zaretskii <eliz@gnu.org> writes:
>> >
>> >> branch: emacs-29
>> >> commit cd05fca5f78048cb867be2d5f0857f6997f12ccc
>> >> Author: Eli Zaretskii <eliz@gnu.org>
>> >> Commit: Eli Zaretskii <eliz@gnu.org>
>> >>
>> >>     ; Improve documentation of 'native-comp-enable-subr-trampolines'
>> >>     
>> >>     * doc/lispref/compile.texi (Native-Compilation Variables):
>> >>     Document the interpretation of non-absolute directory names that
>> >>     are the value of 'native-comp-enable-subr-trampolines'.
>> >
>> >[...]
>> >
>> >> diff --git a/lisp/treesit.el b/lisp/treesit.el
>> >> index b71b5b486d5..297812f23f7 100644
>> >> --- a/lisp/treesit.el
>> >> +++ b/lisp/treesit.el
>> >> @@ -1204,6 +1204,11 @@ See `treesit-simple-indent-presets'.")
>> >>          (cons 'grand-parent
>> >>                (lambda (_n parent &rest _)
>> >>                  (treesit-node-start (treesit-node-parent parent))))
>> >> +        (cons 'great-grand-parent
>> >> +              (lambda (_n parent &rest _)
>> >> +                (treesit-node-start
>> >> +                 (treesit-node-parent
>> >> +                  (treesit-node-parent parent)))))
>> >>          (cons 'parent-bol (lambda (_n parent &rest _)
>> >>                              (save-excursion
>> >>                                (goto-char (treesit-node-start parent))
>> >
>> >This commit contains some Tree-sitter changes that seem unrelated.  Are
>> >they intended?
>> >
>> 
>> If unintended at least they are needed now. Maybe some left over
>> code from one of my patches snuck into your commit?
>
>Yes, sorry.

No worries :)

>
>> I tried looking for that code and was surprised when I couldn't find it 
>> locally :)
>
>If it isn't needed now, feel free to revert, and thanks.

Nono I need it :) preproc directives cannot work without it :)