[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master f17bdee79b1: sgml-mode.el: Cosmetic fixes
From: |
Stefan Monnier |
Subject: |
Re: master f17bdee79b1: sgml-mode.el: Cosmetic fixes |
Date: |
Mon, 17 Jul 2023 08:57:03 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
> Stefan> diff --git a/lisp/textmodes/sgml-mode.el
> b/lisp/textmodes/sgml-mode.el
> Stefan> index b4f5ebf5cd0..d80cdc34775 100644
> Stefan> --- a/lisp/textmodes/sgml-mode.el
> Stefan> +++ b/lisp/textmodes/sgml-mode.el
> Stefan> @@ -66,7 +66,7 @@ When 2, attribute indentation looks like this:
> Stefan> </element>"
> Stefan> :version "25.1"
> Stefan> :type 'integer
> Stefan> - :safe 'integerp)
> Stefan> + :safe #'integerp)
>
> Isnʼt that already enforced by the ':typeʼ keyword?
No.
> If so, we have lots of redundant ':safe' in defcustoms.
It's not redundant: one describe the set of values that are meaningful
(so as to allow Custom to provide a more helpful UI), the other
specifies which values are believed to be safe when coming from
untrusted sources.
They're closely related and often identical, but not always.
Stefan