emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Android port


From: Eli Zaretskii
Subject: Re: Android port
Date: Fri, 04 Aug 2023 13:40:48 +0300

> From: Po Lu <luangruo@yahoo.com>
> Cc: Angelo Graziosi <angelo.g0@libero.it>,  emacs-devel@gnu.org
> Date: Fri, 04 Aug 2023 17:45:20 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Is asprintf used in any code that needs to be run in the MS-Windows
> > build of Emacs?  If not, then the easiest solution is to disable
> > building Gnulib's asprintf via nt/gnulib-cfg.mk.
> 
> No, the Gnulib folks added two new checks to vasnprintf.m4 reflecting
> new C2X features, that weren't present the last time I fixed the Windows
> build.

That doesn't answer my question, AFAICT.  In the current master we
have no uses of asprintf and vasnprintf, so I asked whether it is
needed on the branch, and if so, whether the MS-Windows build uses the
code where these two functions are called.

The way to override Gnulib tests that conclude that some libc function
should be replaced is not to override the feature test (unless that
feature is supported, but Gnulib doesn't know about it -- which can
only happen if we implement the library function inside Emacs).  The
way to override those is to exclude the relevant Gnulib modules from
the Windows build via nt/gnulib-cfg.mk.  If that is not appropriate,
i.e. if the Gnulib module _is_ actually required in the MS-Windows
build, then this is a Gnulib bug that should be reported to them and
fixed by them (but in that case you cannot merge the branch until the
Gnulib folks provide the fix).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]