[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Android port
From: |
Eli Zaretskii |
Subject: |
Re: Android port |
Date: |
Sun, 06 Aug 2023 16:05:10 +0300 |
> From: Po Lu <luangruo@yahoo.com>
> Cc: eggert@cs.ucla.edu, bruno@clisp.org, angelo.g0@libero.it,
> emacs-devel@gnu.org
> Date: Sun, 06 Aug 2023 18:10:32 +0800
>
> diff --git a/nt/mingw-cfg.site b/nt/mingw-cfg.site
> index 425eaace30d..f78ee525bf1 100644
> --- a/nt/mingw-cfg.site
> +++ b/nt/mingw-cfg.site
> @@ -173,3 +173,21 @@ gl_cv_func_nanosleep=yes
> # Suppress configure-time diagnostic from unnecessary libxattr check,
> # as xattr will not be supported here.
> enable_xattr=no
> +# Don't build gnulib printf either.
> +gl_cv_func_printf_sizes_c99=yes
> +gl_cv_func_printf_sizes_c23=yes
> +gl_cv_func_printf_long_double=yes
> +gl_cv_func_printf_infinite_long_double=yes
> +gl_cv_func_printf_directive_a=yes
> +gl_cv_func_printf_directive_b=yes
> +gl_cv_func_printf_directive_f=yes
> +gl_cv_func_printf_directive_n=yes
> +gl_cv_func_printf_directive_ls=yes
> +gl_cv_func_printf_directive_lc=yes
> +gl_cv_func_printf_positions=yes
> +gl_cv_func_printf_flag_grouping=yes
> +gl_cv_func_printf_flag_leftadjust=yes
> +gl_cv_func_printf_flag_zero=yes
> +gl_cv_func_printf_precision=yes
> +gl_cv_func_printf_enomem=yes
> +ac_cv_func_vasprintf=yes
>
> Both the check for vasprintf (Gnulib eschews testing for asprintf, since
> asprintf is never present where vasprintf is not) and the checks for
> printf features are overridden, because Gnulib also tries to replace
> vasprintf if it discovers that the conventional printf functions will
> need to be replaced.
According to my reading of vasprintf.m4, if ac_cv_func_vasprintf=yes,
the rest of the tests, including adding asprintf to LIBOBJ, should not
have happened:
AC_DEFUN([gl_FUNC_VASPRINTF],
[
AC_CHECK_FUNCS([vasprintf])
if test $ac_cv_func_vasprintf = no; then <<<<<<<<<<<<<<<<<<
gl_REPLACE_VASPRINTF
fi
])
Or, if we are using vasprintf-posix.m4 (are we?), then
gl_cv_func_vasprintf_posix should have done that:
AC_DEFUN([gl_FUNC_VASPRINTF_POSIX],
[
AC_REQUIRE([gl_FUNC_VASPRINTF_IS_POSIX])
if test $gl_cv_func_vasprintf_posix = no; then <<<<<<<<<<<<<<<<<<<
gl_PREREQ_VASNPRINTF_WITH_POSIX_EXTRAS
gl_REPLACE_VASNPRINTF
gl_REPLACE_VASPRINTF
fi
])
I see that gl_cv_func_vasprintf_posix is not in your patch to
mingw-cfg.site, so maybe adding that is all that's needed to avoid
overriding all the other gl_cv_func_printf_* variables?
- Re: Android port, (continued)
- Re: Android port, Bruno Haible, 2023/08/06
- Re: Android port, Eli Zaretskii, 2023/08/06
- Re: Android port, Bruno Haible, 2023/08/06
- Re: Android port, Eli Zaretskii, 2023/08/06
- Re: Android port, Bruno Haible, 2023/08/06
- Re: Android port, Eli Zaretskii, 2023/08/06
- Re: Android port,
Eli Zaretskii <=
- Re: Android port, Bruno Haible, 2023/08/06
- Re: Android port, Eli Zaretskii, 2023/08/06
- Re: Android port, Po Lu, 2023/08/06
- Re: Android port, Angelo Graziosi, 2023/08/06
- Re: Android port, Angelo Graziosi, 2023/08/06
- Re: Android port, Angelo Graziosi, 2023/08/06
- Re: Android port, Eli Zaretskii, 2023/08/06
- Re: Android port, Angelo Graziosi, 2023/08/06
- Re: Android port, Eli Zaretskii, 2023/08/06
- Re: Android port, Angelo Graziosi, 2023/08/06