Re: make check produces 25 failures and hangs (bug #65176).

[Andrea Corallo]

Andrea Corallo <acorallo@gnu.org> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> Date: Thu, 10 Aug 2023 23:54:50 +0200
>>> Cc: emacs-devel@gnu.org
>>> From: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
>>> 
>>> On 2023-08-10  22:34, Alan Mackenzie wrote:
>>> 
>>> > So the bugs seem to be triggered by native compilation.
>>> 
>>> Confirmed.  And the hangs seem to be caused by tests asking for input.
>>> 
>>> I executed one of these failing tests interactively
>>> (lisp/abbrev-tests.el), and it kept prompting in the minibuffer
>>> where the usual
>>> 
>>>    (cl-letf (((symbol-function 'read-string) (lambda (&rest _) "<value>")))
>>> 
>>> should have inhibited that.  Full output of that interactive test to
>>> follow:
>>> 
>>> Selector: t
>>> Passed:  18
>>> Failed:  3 (3 unexpected)
>>> Skipped: 1
>>> Total:   22/22
>>> 
>>> Started at:   2023-08-10 23:46:56+0200
>>> Finished.
>>> Finished at:  2023-08-10 23:47:36+0200
>>> 
>>> .............FFFs.....
>>> 
>>> F inverse-add-abbrev-skips-trailing-nonword
>>>      Test that adding an inverse abbrev skips trailing nonword characters.
>>>      (ert-test-failed
>>>       ((should (string= (abbrev-expansion "foo" table) "bar")) :form
>>>        (string= "abc" "bar") :value nil :explanation
>>>        (array-elt 0 (different-atoms (97 "#x61" "?a") (98 "#x62" "?b")))))
>>> 
>>> F inverse-add-abbrev-skips-trailing-nonword/negative-arg
>>>      Test that adding an inverse abbrev skips trailing nonword characters.
>>>      (ert-test-failed
>>>       ((should (string= (abbrev-expansion "text" table) "bar")) :form
>>>        (string= "xxx" "bar") :value nil :explanation
>>>        (array-elt 0 (different-atoms (120 "#x78" "?x") (98 "#x62" "?b")))))
>>> 
>>> F inverse-add-abbrev-skips-trailing-nonword/positive-arg
>>>      Test that adding an inverse abbrev skips trailing nonword characters.
>>>      (ert-test-failed
>>>       ((should (string= (abbrev-expansion "text" table) "bar")) :form
>>>        (string= "xxx" "bar") :value nil :explanation
>>>        (array-elt 0 (different-atoms (120 "#x78" "?x") (98 "#x62" "?b")))))
>>
>> Andrea, could you please look into these test failures?
>
> Yes, will do on Monday.
>
> If in the meanwhile someone could git bisect this I guess it would be
> make the investigation way quicker.
>
>   Andrea

To a very quick look seems to me `comp-subr-trampoline-install' is just
not called as it should.  AFAIR it should be called from Ffset, I'm
really wondering what could have happened.

  Andrea