[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Transient manual
From: |
Jonas Bernoulli |
Subject: |
Re: Transient manual |
Date: |
Sat, 02 Sep 2023 18:31:45 +0200 |
Ihor Radchenko <yantar92@posteo.net> writes:
>> Speaking of af9c063ed, that commit adds another regression and has
>> to be reverted.
>
> Maybe you mean some other commit?
> af9c063ed is just changing a docstring.
Yes. It's e32bd5f7c78c9d92cefd9a78771f9729946fdf73.
Instead of restoring the save-match-data, you could change the order
of the bindings.
When I wrote that function, I decided that I would rather use
save-match-data, even though that could be avoided. That way the two
bindings which set and then refine CMD based on the first submatch are
next to each other, and only after that has been taken care off, do we
move on to set ARGS based on the second submatch. But if you think it
is more important to avoid a save-match-data, or think the mistake you
made is likely to be repeated, I am fine with switching up the order.
Jonas