Re: [ELPA] New package: breadcrumb.el

[João Távora]

Philip Kaludercic <philipk@posteo.net> writes:

> João Távora <joaotavora@gmail.com> writes:

>> Here's a link to the project (which has a screenshot)
>> https://github.com/joaotavora/breadcrumb
>
> Looks nice!  I have no notable comments on the code, except that the
> indentation out of place in two parts of the file.

Thanks, I just spotted that and will fix briefly.

>> Here's the patch for elpa.git
>>
>> diff --git a/elpa-packages b/elpa-packages
>> index 7bbf35a..cfceb7e 100644
>> --- a/elpa-packages
>> +++ b/elpa-packages
>> @@ -99,6 +99,9 @@
>>   (bnf-mode          :url "https://github.com/sergeyklay/bnf-mode";)
>>   (boxy                      :url "https://gitlab.com/tygrdev/boxy";)
>>   (boxy-headings             :url "https://gitlab.com/tygrdev/boxy-headings";)
>> + (breadcrumb                :url "https://github.com/joaotavora/breadcrumb";
>> +                        :readme "README.md"
>
> Are you sure you want to use the README.md file to generate the package
> description, or wouldn't you rather rely on the Commentary section?

Better rely on the Commentary, yes.  Just consider remove that line
removed from the patch.

> Having a "Screenshot" heading followed by nothing might look weird.
>
>> +                        :ignored-files ("screenshot.png"))
>
> If possible, it would be nice to track this on your end with a
> .elpaignore file.

That's perfectlky doable, but I do think it makes a bit more sense like
this.  Why do you think it's "nicer"?  And can we merge it as is for now
(so I can tick this off my todo? ;-)

João