emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Foreground color opacity


From: Filippo Argiolas
Subject: Re: Foreground color opacity
Date: Tue, 12 Sep 2023 06:55:14 +0200

On Tue, Sep 12, 2023 at 4:21 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > > One such example is flyspell.el's flyspell-prog-mode.  See
> > > flyspell-prog-text-faces there.
> >
> > Thanks! That should be easily solvable by adding
> > `font-lock-string-face-clangd-inactive' and the other relevant
> > inactive face variants to `flyspell-prog-text-faces'.
> > FWIW with eglot+clangd (and I guess other servers too) inactive code
> > regions already behave differently because they are not compiled, so
> > you won't get e.g. any flymake diagnostics or inlay hints, so it could
> > be a little less of an issue if something else like flyspell in this
> > case breaks.
>
> My point is that this technique _will_ break features, and I don't
> think it's reasonable to expect each one of them to be fixed
> individually.

Sure and that's a pretty valid point. Thank you for the insight!
I could experiment a bit more with overlays. Maybe setting an overlay
for each node instead of directly changing the face property. Not sure
if that may impact performance though, need to do some test.

My point was that with eglot there are several features that already
do break within inactive regions, at least with clangd, as the
language server rightfully considers them as dead code. Flymake
diagnostics, symbol highlight, documentation on hover, completion come
to mind but there are probably others.

I'll add a known issues section about this in the readme while I look
for a better solution.

Filippo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]