Re: [nongnu] elpa/helm 07dacfe2e2 08/11: Prefer string-match-p over string-suffix-p

[Eli Zaretskii]

> From: Philip Kaludercic <philipk@posteo.net>
> Cc: emacs-devel@gnu.org,  thievol@posteo.net
> Date: Thu, 14 Sep 2023 13:06:47 +0000
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I think this change is simply incorrect: the first argument of
> > string-suffix-p is not interpreted as a regexp, but as a simple
> > literal string (the implementation uses compare-strings internally).
> 
> But why is it incorrect?  `string-suffix-p' is passed a string, while
> `string-match-p' takes a regular expression, that might be too liberal
> but should still match everything the previous check did -- or am I
> missing something?

Why do the change when string-suffix-p already ensures there's nothing
in the second argument after the suffix?