Re: Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d

[Pedro Andres Aranda Gutierrez]

Thank you for the clarification!

The FIXME was sort of misleading here. A double negation always is ;-)

Best, /PA 

On Thu, 21 Sept 2023 at 10:47, Gerd Möllmann <gerd.moellmann@gmail.com> wrote:

On 23-09-21 8:29 , Pedro Andres Aranda Gutierrez wrote:
> Hi
>
> reading removed FIXME in the second hunk:
>
> # FIXME: Don't install the dump file into the app bundle when
> # self-contained install is disabled.
>
> I understand that we should install if self-contained is enabled.
>
> However, I see
>
> +ifeq (${ns_self_contained},no)
>
> Shouldn't that read as
>
> +ifeq (${ns_self_contained},yes)
>
> I'm confused...

I assume that is nextstep/Makefile.in.  We want to cp the .pdmp file
only if we don't do a self-contained build (...=no).

--

Fragen sind nicht da, um beantwortet zu werden,

Fragen sind da um gestellt zu werden

Georg Kreisler

Headaches with a Juju log:

unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run a leader-deposed hook here, but we can't yet