Re: Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d

[Alan Third]

On Thu, Sep 21, 2023 at 10:46:56AM +0200, Gerd Möllmann wrote:
> On 23-09-21 8:29 , Pedro Andres Aranda Gutierrez wrote:
> > Hi
> > 
> > reading removed FIXME in the second hunk:
> > 
> > # FIXME: Don't install the dump file into the app bundle when
> > # self-contained install is disabled.
> > 
> > I understand that we should install if self-contained is enabled.
> > 
> > However, I see
> > 
> > +ifeq (${ns_self_contained},no)
> > 
> > Shouldn't that read as
> > 
> > +ifeq (${ns_self_contained},yes)
> > 
> > I'm confused...
> 
> I assume that is nextstep/Makefile.in.  We want to cp the .pdmp file only if
> we don't do a self-contained build (...=no).

Now I'm confused!

We only have to install the pdmp file in the app bundle when doing a
self-contained build.

If your other change in Makefile.in already does that, then this cp
isn't needed at all.

-- 
Alan Third