[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/phps-mode dd8d800 004/405: Using coloring overlay for c
From: |
Stefan Monnier |
Subject: |
[elpa] externals/phps-mode dd8d800 004/405: Using coloring overlay for comments as well |
Date: |
Sat, 13 Jul 2019 09:59:28 -0400 (EDT) |
branch: externals/phps-mode
commit dd8d800dd3a2e8588e70638dad733c0fe4737cb5
Author: Christian Johansson <address@hidden>
Commit: Christian Johansson <address@hidden>
Using coloring overlay for comments as well
---
phps-lexer.el | 3 +--
tests/php/class.php | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/phps-lexer.el b/phps-lexer.el
index 4ba9eef..a708d6e 100644
--- a/phps-lexer.el
+++ b/phps-lexer.el
@@ -189,7 +189,6 @@
"Move forward to POSITION."
(setq semantic-lex-end-point position))
-;; TODO Use font-lock-syntactic-face-function instead?
(defun phps-mode/COLOR_SYNTAX (token start end)
"Syntax coloring for TOKEN from START to END."
;; Syntax coloring
@@ -213,7 +212,7 @@
(overlay-put (make-overlay start end) 'font-lock-face
'font-lock-variable-name-face))
((string= token 'T_COMMENT)
- (add-text-properties start end '(font-lock-face font-lock-comment-face)))
+ (overlay-put (make-overlay start end) 'font-lock-face
'font-lock-comment-face))
((string= token 'T_DOC_COMMENT)
(overlay-put (make-overlay start end) 'font-lock-face
'font-lock-comment-delimiter-face))
diff --git a/tests/php/class.php b/tests/php/class.php
index e43c12b..05a5e11 100644
--- a/tests/php/class.php
+++ b/tests/php/class.php
@@ -1,7 +1,7 @@
<?php
/**
* Some comments here
- * @todo was here
+ * @todo was here
*/
class MyClass {
- [elpa] branch externals/phps-mode created (now f5c2072), Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 7d0cd36 002/405: Updated goals, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode dd8d800 004/405: Using coloring overlay for comments as well,
Stefan Monnier <=
- [elpa] externals/phps-mode c64b3b4 008/405: More work on lexer tests, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode a724438 010/405: Handled lexing with empty single and double quote string, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 5a6a96b 012/405: Added another test, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode b3a6308 015/405: Added hook for resetting lexer variables, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode ce656a5 006/405: More general cleaning up, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode f3205d5 011/405: Fixed lexing of basic tokens, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 31ca9d5 007/405: More cleaning up, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 79040dc 005/405: Some cleaning up, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 394f7ae 017/405: Fixed issue with empty strings before non-empty strings, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 41c4fbb 009/405: Lexer unit tests now working, Stefan Monnier, 2019/07/13