[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/phps-mode 3824abf 060/405: Resolved indent with trailin
From: |
Stefan Monnier |
Subject: |
[elpa] externals/phps-mode 3824abf 060/405: Resolved indent with trailing parenthesis |
Date: |
Sat, 13 Jul 2019 09:59:43 -0400 (EDT) |
branch: externals/phps-mode
commit 3824abf1a70e064e95b952a8412934af0840c3c6
Author: Christian Johansson <address@hidden>
Commit: Christian Johansson <address@hidden>
Resolved indent with trailing parenthesis
---
phps-functions.el | 9 +++++----
phps-test-functions.el | 4 ++++
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/phps-functions.el b/phps-functions.el
index 497a0fd..8b20457 100644
--- a/phps-functions.el
+++ b/phps-functions.el
@@ -39,8 +39,7 @@
(defvar phps-mode/buffer-changes--start nil
"Start of buffer changes, nil if none.")
-;; TODO Should also format white-space inside the line, i.e. after function
declarations?
-;; TODO Should indent doc blocks with 1 space
+;; TODO Also format white-space inside the line, i.e. after function
declarations?
(defun phps-mode/indent-line ()
"Indent line."
(let ((data (phps-mode/get-point-data)))
@@ -73,9 +72,11 @@
(while (and valid-tokens
(<= token-number end-token-number))
(let ((token (car (nth token-number phps-mode/lexer-tokens)))
- (token-start (car (cdr (nth token-number
phps-mode/lexer-tokens)))))
+ (token-start (car (cdr (nth token-number
phps-mode/lexer-tokens))))
+ (token-end (cdr (cdr (nth token-number
phps-mode/lexer-tokens)))))
(when (and valid-tokens
- (>= token-start (point))
+ (or (>= token-start (point))
+ (>= token-end (point)))
(not (or
(string= token "{")
(string= token "}")
diff --git a/phps-test-functions.el b/phps-test-functions.el
index 5b695cc..17cced3 100644
--- a/phps-test-functions.el
+++ b/phps-test-functions.el
@@ -186,6 +186,10 @@
(goto-char 50)
(should (equal (list (list t 0 0 0 nil nil) (list t 0 0 0 nil nil))
(phps-mode/get-point-data))))
+ (phps-mode/with-test-buffer
+ "<?php\n$variable = array(\n'random4');\n$variable = true;\n"
+ (goto-char 29)
+ (should (equal (list (list t 0 1 0 4 nil) (list t 0 0 0 7 nil))
(phps-mode/get-point-data))))
)
;; TODO Add tests for all examples here: https://www.php-fig.org/psr/psr-2/
- [elpa] externals/phps-mode be46d9c 044/405: Added lexer autoload to functions, (continued)
- [elpa] externals/phps-mode be46d9c 044/405: Added lexer autoload to functions, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode a259292 047/405: Changed indentation function to work solely on tokens, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 4098f46 049/405: Started with incremental lexer, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode da1d1de 051/405: Temporary lexer after change until other work is ready, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 990d3dd 054/405: Added test for indentation of multiple-line doc comment, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode dd80d27 055/405: Started work on detecting doc comment blocks, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode e1b7160 053/405: (newline-and-indent) now working, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 8aa1ab6 059/405: Another test for getting point data inside doc block, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 09daec3 052/405: Foundation for incremental lexer and syntax colorer completed, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 3f4c344 056/405: Fixed detection of doc comment blocks, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 3824abf 060/405: Resolved indent with trailing parenthesis,
Stefan Monnier <=
- [elpa] externals/phps-mode a61cb8b 062/405: Fixed issue with doc comment indentation, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 6c597fb 065/405: Updated readme, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 0ca9fe8 058/405: Detection of point inside doc comment block improved, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 67f9a7a 057/405: Moved lexer-get-point-data to functions, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 27cd705 069/405: Updated readme, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 58300fd 070/405: More updates of readme, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 86ec35f 066/405: Incremental lexer working somewhat, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode ec71e15 074/405: Fixed bug where token-numbers are not defined, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 236f05e 071/405: Updated makefile to not use hard-coded path to emacs, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode bf633d2 061/405: Added test for indent of final line of doc comment block, Stefan Monnier, 2019/07/13