[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/phps-mode 22f75ba 362/405: Advice is running again in u
From: |
Stefan Monnier |
Subject: |
[elpa] externals/phps-mode 22f75ba 362/405: Advice is running again in unit test |
Date: |
Sat, 13 Jul 2019 10:00:49 -0400 (EDT) |
branch: externals/phps-mode
commit 22f75baf02e8e6e68529f4b25faa204100571e38
Author: Christian Johansson <address@hidden>
Commit: Christian Johansson <address@hidden>
Advice is running again in unit test
---
phps-mode-functions.el | 3 ++-
phps-mode-test-functions.el | 6 +++---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/phps-mode-functions.el b/phps-mode-functions.el
index 0ca4031..c63e97d 100644
--- a/phps-mode-functions.el
+++ b/phps-mode-functions.el
@@ -811,6 +811,7 @@
(apply old-function arguments)
(if looking-at-whitespace
(progn
+ (message "Looking at white-space")
(setq new-pos (point))
(let ((diff (- new-pos old-pos)))
(when (> diff 0)
@@ -983,7 +984,7 @@
(set (make-local-variable 'indent-tabs-mode) nil))
;; Add support for moving indexes quickly when making newlines
- (advice-add 'newline :around #'phps-mode-functions-around-newline)
+ (advice-add #'newline :around #'phps-mode-functions-around-newline)
;; Reset flags
(set (make-local-variable 'phps-mode-functions-buffer-changes-start) nil)
diff --git a/phps-mode-test-functions.el b/phps-mode-test-functions.el
index 4052d76..bcce4f9 100644
--- a/phps-mode-test-functions.el
+++ b/phps-mode-test-functions.el
@@ -861,11 +861,11 @@
"Add newline between two assignments and inspect moved tokens and states"
(message "Tokens %s" (phps-mode-lexer-get-tokens))
(should (equal (phps-mode-lexer-get-tokens)
- '((T_OPEN_TAG 1 . 7) (T_VARIABLE 7 . 11) ("=" 12 . 13)
(T_CONSTANT_ENCAPSED_STRING 14 . 19) (";" 19 . 20) (T_VARIABLE 22 . 27) ("=" 28
. 29) (T_CONSTANT_ENCAPSED_STRING 30 . 35) (";" 35. 36))))
+ '((T_OPEN_TAG 1 . 7) (T_VARIABLE 7 . 11) ("=" 12 . 13)
(T_CONSTANT_ENCAPSED_STRING 14 . 19) (";" 19 . 20) (T_VARIABLE 22 . 27) ("=" 28
. 29) (T_CONSTANT_ENCAPSED_STRING 30 . 35) (";" 35 . 36))))
(goto-char 21)
- (newline-and-indent)
+ (newline nil t)
(should (equal (phps-mode-lexer-get-tokens)
- '((T_OPEN_TAG 1 . 7) (T_VARIABLE 7 . 11) ("=" 12 . 13)
(T_CONSTANT_ENCAPSED_STRING 14 . 19) (";" 19 . 20) (T_VARIABLE 23 . 28) ("=" 29
. 30) (T_CONSTANT_ENCAPSED_STRING 31 . 36) (";" 36. 37))))))
+ '((T_OPEN_TAG 1 . 7) (T_VARIABLE 7 . 11) ("=" 12 . 13)
(T_CONSTANT_ENCAPSED_STRING 14 . 19) (";" 19 . 20) (T_VARIABLE 23 . 28) ("=" 29
. 30) (T_CONSTANT_ENCAPSED_STRING 31 . 36) (";" 36 . 37))))))
(defun phps-mode-test-functions ()
"Run test for functions."
- [elpa] externals/phps-mode 38bd348 361/405: More work on advice, (continued)
- [elpa] externals/phps-mode 38bd348 361/405: More work on advice, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 2efd7d7 367/405: Started on function to move line-indent index, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 5bc592a 368/405: More work on moving indent indexes, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode bc1f50f 365/405: Fixed byte-compilation in functions unit-test, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 654ef5f 377/405: Added another state test for newline, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode fe80a3a 369/405: Passes test for moving line-indents down, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 07ed24d 376/405: Added states test as well, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 92e53e8 363/405: Passes test for pressing newline before white-spaces just moves meta-data, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode f2ff34a 378/405: Added TODO items for making changes inside tokens and not triggered a full re-lexing, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode d416443 371/405: Added more test for moving line-indent index, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 22f75ba 362/405: Advice is running again in unit test,
Stefan Monnier <=
- [elpa] externals/phps-mode 4592bce 385/405: Only running newline heuristic when rest of line is whitespace, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode a14d5b2 399/405: Mode map is now loaded, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode ff474c9 392/405: Work on invalid imenu, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode defa128 393/405: Passes unit test for imenu new structure, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode a48386a 386/405: Do not allow failures on emacs snapshot, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 3f20bd2 394/405: Updated tests and structure of hierarchical imenu, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode ba7a3dc 381/405: Updated TODO list with travis integration completed, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 3c959d3 404/405: Improved README, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 895105d 384/405: Updated emacs version requirement and travis build, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode b7b778b 379/405: Updated Travis CI build script, Stefan Monnier, 2019/07/13