[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/geiser-guile dc8a792 257/284: Use (car (process-lines ...)
From: |
Philip Kaludercic |
Subject: |
[nongnu] elpa/geiser-guile dc8a792 257/284: Use (car (process-lines ...)) instead of (shell-command ...) |
Date: |
Sun, 1 Aug 2021 18:29:56 -0400 (EDT) |
branch: elpa/geiser-guile
commit dc8a7929f4cfcffe59cbb3a83d61cf9273207112
Author: Jordan Brown <mrhmouse@gmail.com>
Commit: Jose Antonio Ortega Ruiz <jao@gnu.org>
Use (car (process-lines ...)) instead of (shell-command ...)
`shell-command` assumes Bourne-shell-compatible quoting, which
doesn't work when the user isn't using a Bourne-compatible shell.
Instead of futzing about with quoting, we can just use `process-lines`
to execute a process and pass it arguments directly.
---
elisp/geiser-guile.el | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/elisp/geiser-guile.el b/elisp/geiser-guile.el
index de2e23f..dacca55 100644
--- a/elisp/geiser-guile.el
+++ b/elisp/geiser-guile.el
@@ -334,10 +334,7 @@ This function uses `geiser-guile-init-file' if it exists."
(defconst geiser-guile-minimum-version "2.0")
(defun geiser-guile--version (binary)
- (shell-command-to-string
- (format "%s -c %s"
- (shell-quote-argument binary)
- (shell-quote-argument "(display (version))"))))
+ (car (process-lines binary "-c" "(display (version))")))
(defun geiser-guile-update-warning-level ()
"Update the warning level used by the REPL.
- [nongnu] elpa/geiser-guile bc80639 194/284: Merge branch 'master' into guile-meta, (continued)
- [nongnu] elpa/geiser-guile bc80639 194/284: Merge branch 'master' into guile-meta, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile 9d26fb3 201/284: Debugger support, and Guile using it, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile a000bd1 217/284: Guile nit, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile f6911b5 218/284: New geiser-add-to-load-path, just for Guile right now, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile f017454 221/284: Bug fix: don't override customized geiser-implementations-alist, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile 8624afc 229/284: Finishing removal of the "foo ends here" footers, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile 85bf381 244/284: guile: pretty printing evaluation results (#64), Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile 452e096 235/284: White space, really, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile 2f91e2e 245/284: Ensuring switch-to-geiser asks for an implementation, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile f5fee3b 255/284: Quoting binary on version checks (issue #117), Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile dc8a792 257/284: Use (car (process-lines ...)) instead of (shell-command ...),
Philip Kaludercic <=
- [nongnu] elpa/geiser-guile 20043b1 271/284: Make guile return line numbers more often, as suggested by Sergey, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile 5eff1e4 279/284: preparing MELPA submission, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile 4044010 060/284: Support for multiple Scheme implementations, Chapter 1., Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile ed29f9f 103/284: Guile: bug in backtrace display fixed., Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile 567f3ba 129/284: Guile: dead elisp code elimination., Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile 23e1ec2 169/284: Documentation nits, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile 5532387 171/284: Guile: remote REPLs (connect-to-guile), Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile 7a25131 161/284: Guile: fixes for compilation error regexps, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile 9ff3140 083/284: Guile: backtrace buttonization., Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-guile 7b0d68b 117/284: Guile: better stack traces (using start-stack to delimit them)., Philip Kaludercic, 2021/08/01