[nongnu] elpa/geiser-kawa 0f5c744 016/119: Avoid issues with older Kawa versions when using quickstart.el

[Philip Kaludercic]

branch: elpa/geiser-kawa
commit 0f5c744b873c3d0ff5921dbf979a4499bddb9f65
Author: spellcard199 <spellcard199@protonmail.com>
Commit: spellcard199 <spellcard199@protonmail.com>

    Avoid issues with older Kawa versions when using quickstart.el
---
 README.org    | 12 ++++++++++--
 quickstart.el |  4 ++--
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/README.org b/README.org
index b7fe2d3..400431f 100644
--- a/README.org
+++ b/README.org
@@ -34,10 +34,16 @@ kawa- and java-specific:
 - completion for java methods
 - completion for java classes
 
+** Supported Kawa versions
+:PROPERTIES:
+:CUSTOM_ID:       85b51f74-b1b2-4863-a888-0b11580321f3
+:END:
+
+Only versions of Kawa > 3.1 are supported, mostly due to the fact that before 
the 3.1 release some necessary Kawa classes were private.
+
 ** Try geiser-kawa without modifying your emacs configuration
 
 1. Get Emacs, Cask, Maven and make them available through your $PATH
-     - Kawa is optional, but if you make the =kawa= executable available in 
your PATH you can use it too
 2. Clone this repository
 3. cd into the cloned dir
 4. Tell cask to install emacs dependencies with:
@@ -45,7 +51,9 @@ kawa- and java-specific:
 5. Pull [[http://gitlab.com/spellcard199/kawa-geiser][kawa-geiser]] maven 
dependencies (the first time takes ~1 minute), compile them and start 
geiser-kawa's scratch buffer and repl with:
   : cask emacs -Q --load quickstart.el
 
-The reason Kawa is optional is that =quickstart.el= calls =mvn package= 
(wrapped by =geiser-kawa-compile-java-dependencies=), which produces a jar that 
includes the compiled [[https://gitlab.com/groups/kashell/][Kawa's master 
branch]]
+The reason you don't need Kawa to try geiser-kawa is that =quickstart.el=:
+1. calls =mvn package= (wrapped by =geiser-kawa-compile-java-dependencies=), 
which produces a jar that includes the compiled 
[[https://gitlab.com/groups/kashell/][Kawa's master branch]]
+2. sets the variable =geiser-kawa-use-kawa-version-included-in-kawa-geiser= to 
=t=, to avoid issues with [[85b51f74-b1b2-4863-a888-0b11580321f3][older kawa 
versions]]
 
 ** Cask issue with geiser
 
diff --git a/quickstart.el b/quickstart.el
index 2ebafcb..74f99cd 100644
--- a/quickstart.el
+++ b/quickstart.el
@@ -8,8 +8,8 @@
 (require 'geiser-kawa)
 (require 'geiser-mode)
 (defun run-kawa-after-compilation-finishes (buffer desc)
-  (when (not (executable-find geiser-kawa-binary))
-    (setq geiser-kawa-use-kawa-version-included-in-kawa-geiser t))
+  ;; Use included Kawa, to avoid issues with unsupported old Kawa versions (< 
3.1.1)
+  (setq geiser-kawa-use-kawa-version-included-in-kawa-geiser t)
   (run-kawa)
   (switch-to-buffer-other-window "*scratch*")
   (geiser-impl--set-buffer-implementation 'kawa)