[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/geiser-racket 14330b4 148/191: Racket: not loading errortr
From: |
Philip Kaludercic |
Subject: |
[nongnu] elpa/geiser-racket 14330b4 148/191: Racket: not loading errortrace by default |
Date: |
Sun, 1 Aug 2021 18:32:18 -0400 (EDT) |
branch: elpa/geiser-racket
commit 14330b43b9e3fbf97c36ad580ae44f644e19a151
Author: Jose Antonio Ortega Ruiz <jao@gnu.org>
Commit: Jose Antonio Ortega Ruiz <jao@gnu.org>
Racket: not loading errortrace by default
The new submodules and errortrace interact badly, for what i've seen.
In particular, even with the submodule[+*] loading correctly, its
namespace doesn't have all identifiers bound, and new ones seem to
appear in the bindings lists (things like a.1 or b.2, when a and b are
the actual identifiers defined inside the module).
Since moreover someone mentioned in the devel ML that errortrace is in
general terms buggy, i guess we can leave without it for the time
being.
---
geiser/enter.rkt | 5 +----
geiser/startup.rkt | 2 +-
geiser/user.rkt | 13 ++++++-------
3 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/geiser/enter.rkt b/geiser/enter.rkt
index 0ef9ac5..7416c46 100644
--- a/geiser/enter.rkt
+++ b/geiser/enter.rkt
@@ -67,9 +67,7 @@
(list 'file (or (and m (mod-load-path m)) path-str))))
(define (add-paths! m ps)
- (let* ([name (mod-name m)]
- [pm (if (pair? name) (lambda (p) (cons p (cdr name))) (lambda (p)
p))])
- (for-each (lambda (p) (hash-set! loaded (pm p) m)) ps)))
+ (for-each (lambda (p) (hash-set! loaded p m)) ps))
(define (resolve-paths path)
(define (find root rest)
@@ -99,7 +97,6 @@
(parameterize ([compile-enforce-module-constants #f])
(compile e)))
(lambda (ext loader?) (load-extension ext) #f)
- #:submodule-path (if (pair? name) (cdr name) '())
#:notify (lambda (chosen) (notify re? chosen))))
(define ((make-loader orig re?) path name)
diff --git a/geiser/startup.rkt b/geiser/startup.rkt
index bf9293b..d766dcd 100644
--- a/geiser/startup.rkt
+++ b/geiser/startup.rkt
@@ -15,7 +15,7 @@
"Racket version 5.0 or better required (found ~a)"
(version)))
-(require errortrace)
+;; (require errortrace)
(require geiser/user)
(init-geiser-repl)
diff --git a/geiser/user.rkt b/geiser/user.rkt
index d570a39..d8ac0b2 100644
--- a/geiser/user.rkt
+++ b/geiser/user.rkt
@@ -29,8 +29,8 @@
(define (do-enter mod name)
(visit-module mod)
- (current-namespace (module->namespace mod))
- (last-entered name))
+ (last-entered name)
+ (current-namespace (module->namespace mod)))
(define (file-mod? mod)
(and (list? mod)
@@ -61,9 +61,6 @@
[(submod-path mod) => (lambda (m) (do-enter m m))]
[else (module-error stx mod)]))
-(define orig-loader (current-load/use-compiled))
-(define geiser-loader (module-loader orig-loader))
-
(define (geiser-eval)
(define geiser-main (module->namespace 'geiser))
(define (eval-here form) (eval form geiser-main))
@@ -120,9 +117,11 @@
(define (geiser-prompt-read prompt)
(make-repl-reader (geiser-read prompt)))
+(define (geiser-loader) (module-loader (current-load/use-compiled)))
+
(define (init-geiser-repl)
(compile-enforce-module-constants #f)
- (current-load/use-compiled geiser-loader)
+ (current-load/use-compiled (geiser-loader))
(preload-help)
(current-prompt-read (geiser-prompt-read geiser-prompt))
(current-print maybe-print-image))
@@ -132,7 +131,7 @@
(current-input-port in)
(current-output-port out)
(current-error-port out)
- (current-load/use-compiled geiser-loader)
+ (current-load/use-compiled (geiser-loader))
(current-prompt-read (geiser-prompt-read geiser-prompt))
(current-print maybe-print-image)]
(preload-help)
- [nongnu] elpa/geiser-racket b86cf1f 116/191: Configurable keyword case sensitivity, (continued)
- [nongnu] elpa/geiser-racket b86cf1f 116/191: Configurable keyword case sensitivity, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket e4707d2 105/191: racket: autodoc for PLAI's define-type, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 90c38d6 121/191: A better solution to the funky filename problem, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket cc2b8a3 126/191: Racket: fixing help when REPL is in a module, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket c897d9e 130/191: Racket: fixing error backtrace cleansing, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 3d41f16 133/191: Racket: correct font-lock for define/match, again, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket e855c05 135/191: racket: , enter submodules, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 023cb2b 137/191: racket: indentation for module*, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 1e62c8f 151/191: Let's make it *any* submodule, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket a608b02 150/191: Racket: new commands to show and hide test submodules, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 14330b4 148/191: Racket: not loading errortrace by default,
Philip Kaludercic <=
- [nongnu] elpa/geiser-racket 44740d1 152/191: Syntax error fixed, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 5e0fced 161/191: Possible fix for scanning problem, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket bde687f 153/191: Scheme version checks, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket f9b1681 159/191: Font lock `define-syntax-rule' like `define' procedures, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 87662a1 164/191: Not cleaning the image cache before displaying images, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket e989bba 165/191: Add 'geiser-syntax--simple-keywords', Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 279714a 157/191: Racket: fix for recompilation of typed/racket modules, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 05f692b 184/191: geiser-racket.el to top-level to easy elpa definition, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket a87fd44 190/191: fix: auto-activate implementation, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 22e56ce 191/191: Use new implementation extension declarator, Philip Kaludercic, 2021/08/01