[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/geiser-mit d50226f 05/29: Use (car (process-lines ...)) in
From: |
Philip Kaludercic |
Subject: |
[nongnu] elpa/geiser-mit d50226f 05/29: Use (car (process-lines ...)) instead of (shell-command ...) |
Date: |
Sun, 1 Aug 2021 18:31:02 -0400 (EDT) |
branch: elpa/geiser-mit
commit d50226fd528aa8ccf8442bbd055a483cb776658b
Author: Jordan Brown <mrhmouse@gmail.com>
Commit: Jose Antonio Ortega Ruiz <jao@gnu.org>
Use (car (process-lines ...)) instead of (shell-command ...)
`shell-command` assumes Bourne-shell-compatible quoting, which
doesn't work when the user isn't using a Bourne-compatible shell.
Instead of futzing about with quoting, we can just use `process-lines`
to execute a process and pass it arguments directly.
---
elisp/geiser-mit.el | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/elisp/geiser-mit.el b/elisp/geiser-mit.el
index 5e61cf1..fffcfb6 100644
--- a/elisp/geiser-mit.el
+++ b/elisp/geiser-mit.el
@@ -120,10 +120,12 @@ This function uses `geiser-mit-init-file' if it exists."
(defconst geiser-mit-minimum-version "9.1.1")
(defun geiser-mit--version (binary)
- (shell-command-to-string
- (format "%s --quiet --no-init-file --eval %s"
- (shell-quote-argument binary)
- "'(begin (display (get-subsystem-version-string \"Release\"))
(%exit 0))'")))
+ (car (process-lines binary
+ "--quiet"
+ "--no-init-file"
+ "--eval"
+ "(begin (display (get-subsystem-version-string
\"Release\"))
+ (%exit 0))")))
(defconst geiser-mit--path-rx "^In \\([^:\n ]+\\):\n")
(defun geiser-mit--startup (remote)
- [nongnu] elpa/geiser-mit 5191d62 23/29: Register mit in geiser-active-implementations, (continued)
- [nongnu] elpa/geiser-mit 5191d62 23/29: Register mit in geiser-active-implementations, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-mit 27ae93b 19/29: typo, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-mit 96845db 28/29: readme.org updates, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-mit 1caea83 26/29: Simple-minded implementation guessing function, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-mit d17394f 29/29: fix: auto-activate implementation, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-mit def6bbe 09/29: Removing geiser-mit's dep on subr-x altogether, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-mit c49a2ee 15/29: Use cl-lib instead of cl, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-mit 9d7c2a8 10/29: Support scmutils, a big library for mit-scheme, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-mit 14ae488 24/29: Unused variable, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-mit e4f4340 08/29: Only requiring subr-x under eval-when compile, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-mit d50226f 05/29: Use (car (process-lines ...)) instead of (shell-command ...),
Philip Kaludercic <=
- [nongnu] elpa/geiser-mit 4f3f89d 25/29: readme update, Philip Kaludercic, 2021/08/01