emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/geiser-mit d50226f 05/29: Use (car (process-lines ...)) in


From: Philip Kaludercic
Subject: [nongnu] elpa/geiser-mit d50226f 05/29: Use (car (process-lines ...)) instead of (shell-command ...)
Date: Sun, 1 Aug 2021 18:31:02 -0400 (EDT)

branch: elpa/geiser-mit
commit d50226fd528aa8ccf8442bbd055a483cb776658b
Author: Jordan Brown <mrhmouse@gmail.com>
Commit: Jose Antonio Ortega Ruiz <jao@gnu.org>

    Use (car (process-lines ...)) instead of (shell-command ...)
    
    `shell-command` assumes Bourne-shell-compatible quoting, which
    doesn't work when the user isn't using a Bourne-compatible shell.
    
    Instead of futzing about with quoting, we can just use `process-lines`
    to execute a process and pass it arguments directly.
---
 elisp/geiser-mit.el | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/elisp/geiser-mit.el b/elisp/geiser-mit.el
index 5e61cf1..fffcfb6 100644
--- a/elisp/geiser-mit.el
+++ b/elisp/geiser-mit.el
@@ -120,10 +120,12 @@ This function uses `geiser-mit-init-file' if it exists."
 (defconst geiser-mit-minimum-version "9.1.1")
 
 (defun geiser-mit--version (binary)
-  (shell-command-to-string
-   (format "%s --quiet --no-init-file --eval %s"
-           (shell-quote-argument binary)
-           "'(begin (display (get-subsystem-version-string \"Release\")) 
(%exit 0))'")))
+  (car (process-lines binary
+                      "--quiet"
+                      "--no-init-file"
+                      "--eval"
+                      "(begin (display (get-subsystem-version-string 
\"Release\"))
+                              (%exit 0))")))
 
 (defconst geiser-mit--path-rx "^In \\([^:\n ]+\\):\n")
 (defun geiser-mit--startup (remote)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]