[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/geiser-racket 7f89d8f 170/191: Use (car (process-lines ...
From: |
Philip Kaludercic |
Subject: |
[nongnu] elpa/geiser-racket 7f89d8f 170/191: Use (car (process-lines ...)) instead of (shell-command ...) |
Date: |
Sun, 1 Aug 2021 18:32:22 -0400 (EDT) |
branch: elpa/geiser-racket
commit 7f89d8f2049f6149618f32f47e1c80de586d7b51
Author: Jordan Brown <mrhmouse@gmail.com>
Commit: Jose Antonio Ortega Ruiz <jao@gnu.org>
Use (car (process-lines ...)) instead of (shell-command ...)
`shell-command` assumes Bourne-shell-compatible quoting, which
doesn't work when the user isn't using a Bourne-compatible shell.
Instead of futzing about with quoting, we can just use `process-lines`
to execute a process and pass it arguments directly.
---
elisp/geiser-racket.el | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/elisp/geiser-racket.el b/elisp/geiser-racket.el
index ac7626a..c51b08c 100644
--- a/elisp/geiser-racket.el
+++ b/elisp/geiser-racket.el
@@ -363,10 +363,7 @@ using start-geiser, a procedure in the geiser/server
module."
(defvar geiser-racket-minimum-version "5.3")
(defun geiser-racket--version (binary)
- (shell-command-to-string
- (format "%s -e %s"
- (shell-quote-argument binary)
- (shell-quote-argument "(display (version))"))))
+ (car (process-lines binary "-e" "(display (version))")))
(defvar geiser-racket--image-cache-dir nil)
- [nongnu] elpa/geiser-racket 36d2d55 097/191: racket: reading into elisp-land the cache dir as needed, (continued)
- [nongnu] elpa/geiser-racket 36d2d55 097/191: racket: reading into elisp-land the cache dir as needed, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 1f7a9e2 124/191: Racket: better help commands, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket b23d52d 123/191: Racket: better help commands, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket a5f8702 132/191: Racket: correct font lock for define/match, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 4e68ebc 140/191: racket: C-u C-c C-z on a submodule enters it, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 65447c4 138/191: racket: handling correctly submodules in load handler during , enter, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket e1474f1 141/191: Nits, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket eafee8d 142/191: racket: new , geiser-load command in REPL, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket e311818 154/191: Racket: duplicate version check removed, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket c6b4c09 155/191: Racket: fix for evaluations inside typed/racket modules, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 7f89d8f 170/191: Use (car (process-lines ...)) instead of (shell-command ...),
Philip Kaludercic <=
- [nongnu] elpa/geiser-racket a0532bc 169/191: Quoting binary on version checks (issue #117), Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 5a7b12c 179/191: Fix typos, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 0cb58c8 183/191: racket server to access via geiser-connect, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 18cb3b3 185/191: README.md, Philip Kaludercic, 2021/08/01
- [nongnu] elpa/geiser-racket 1996cca 187/191: Ready for MELPA, Philip Kaludercic, 2021/08/01