emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/geiser-racket 7f89d8f 170/191: Use (car (process-lines ...


From: Philip Kaludercic
Subject: [nongnu] elpa/geiser-racket 7f89d8f 170/191: Use (car (process-lines ...)) instead of (shell-command ...)
Date: Sun, 1 Aug 2021 18:32:22 -0400 (EDT)

branch: elpa/geiser-racket
commit 7f89d8f2049f6149618f32f47e1c80de586d7b51
Author: Jordan Brown <mrhmouse@gmail.com>
Commit: Jose Antonio Ortega Ruiz <jao@gnu.org>

    Use (car (process-lines ...)) instead of (shell-command ...)
    
    `shell-command` assumes Bourne-shell-compatible quoting, which
    doesn't work when the user isn't using a Bourne-compatible shell.
    
    Instead of futzing about with quoting, we can just use `process-lines`
    to execute a process and pass it arguments directly.
---
 elisp/geiser-racket.el | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/elisp/geiser-racket.el b/elisp/geiser-racket.el
index ac7626a..c51b08c 100644
--- a/elisp/geiser-racket.el
+++ b/elisp/geiser-racket.el
@@ -363,10 +363,7 @@ using start-geiser, a procedure in the geiser/server 
module."
 (defvar geiser-racket-minimum-version "5.3")
 
 (defun geiser-racket--version (binary)
-  (shell-command-to-string
-   (format "%s  -e %s"
-           (shell-quote-argument binary)
-           (shell-quote-argument "(display (version))"))))
+  (car (process-lines binary "-e" "(display (version))")))
 
 (defvar geiser-racket--image-cache-dir nil)
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]