emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/lua-mode 0a1e915 262/468: bug fixes for show/hide process


From: Philip Kaludercic
Subject: [nongnu] elpa/lua-mode 0a1e915 262/468: bug fixes for show/hide process buffer
Date: Thu, 5 Aug 2021 04:58:49 -0400 (EDT)

branch: elpa/lua-mode
commit 0a1e9156af9cd7b8b95a49f9d7af3a7033d7fdea
Author: xristos <xristos@sdf.lonestar.org>
Commit: xristos <xristos@sdf.lonestar.org>

    bug fixes for show/hide process buffer
    
    + Show Process Buffer will create a Lua process if one doesn't exist
    
    + Hide process buffer works correctly when buffer gets killed or is nil
      (delete-windows-on nil) could be executed before, which will do
      the wrong thing
---
 lua-mode.el | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/lua-mode.el b/lua-mode.el
index 3405c4a..cac66e0 100644
--- a/lua-mode.el
+++ b/lua-mode.el
@@ -1665,8 +1665,9 @@ When called interactively, switch to the process buffer."
 (defun lua-kill-process ()
   "Kill lua subprocess and its buffer."
   (interactive)
-  (if lua-process-buffer
-      (kill-buffer lua-process-buffer)))
+  (when lua-process-buffer
+    (kill-buffer lua-process-buffer)
+    (setq lua-process-buffer nil)))
 
 (defun lua-set-lua-region-start (&optional arg)
   "Set start of region for use with `lua-send-lua-region'."
@@ -1764,14 +1765,17 @@ Otherwise, return START."
   (lua-send-buffer))
 
 (defun lua-show-process-buffer ()
-  "Make sure `lua-process-buffer' is being displayed."
+  "Make sure `lua-process-buffer' is being displayed.
+Create a Lua process if one doesn't already exist."
   (interactive)
-  (display-buffer lua-process-buffer))
+  (display-buffer (process-buffer (lua-get-create-process))))
+
 
 (defun lua-hide-process-buffer ()
   "Delete all windows that display `lua-process-buffer'."
   (interactive)
-  (delete-windows-on lua-process-buffer))
+  (when (buffer-live-p lua-process-buffer)
+    (delete-windows-on lua-process-buffer)))
 
 (defun lua-funcname-at-point ()
   "Get current Name { '.' Name } sequence."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]