emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/lua-mode 459e3b7 427/468: Fix FIXME: `lua-prefix-key' is a


From: Philip Kaludercic
Subject: [nongnu] elpa/lua-mode 459e3b7 427/468: Fix FIXME: `lua-prefix-key' is always `boundp'
Date: Thu, 5 Aug 2021 04:59:22 -0400 (EDT)

branch: elpa/lua-mode
commit 459e3b7c39a264c7042820304f0c8c92b1d6c6c4
Author: Nikita Bloshchanevich <nikblos@outlook.com>
Commit: Nikita Bloshchanevich <nikblos@outlook.com>

    Fix FIXME: `lua-prefix-key' is always `boundp'
    
    Due to being defined previously in the module, it would always be bound. 
What
    the author presumably meant was to check if it is nil, so that all keys in
    `lua-prefix-mode-map' would be defined inline, without a prefix.
---
 lua-mode.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lua-mode.el b/lua-mode.el
index 4618a6d..4656016 100644
--- a/lua-mode.el
+++ b/lua-mode.el
@@ -361,12 +361,11 @@ If the latter is nil, the keymap translates into 
`lua-mode-map' verbatim.")
     (define-key result-map [menu-bar lua-mode] (cons "Lua" lua-mode-menu))
     (define-key result-map [remap backward-up-list] 'lua-backward-up-list)
 
-    ;; FIXME: see if the declared logic actually works
     ;; handle prefix-keyed bindings:
     ;; * if no prefix, set prefix-map as parent, i.e.
     ;;      if key is not defined look it up in prefix-map
     ;; * if prefix is set, bind the prefix-map to that key
-    (if (boundp 'lua-prefix-key)
+    (if lua-prefix-key
         (define-key result-map (vector lua-prefix-key) lua-prefix-mode-map)
       (set-keymap-parent result-map lua-prefix-mode-map))
     result-map)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]