[nongnu] elpa/with-editor ba4ca8a 108/140: with-editor-finish: Fix bug concerning git-commit-post-finish-hook

[Jonas Bernoulli]

branch: elpa/with-editor
commit ba4ca8ab34c17fbc4c7af5b9b42c6d3836b48e1a
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    with-editor-finish: Fix bug concerning git-commit-post-finish-hook
    
    `git-commit-post-finish-hook' is intended to be set locally.  Because
    the buffer in which it is locally does not exist anymore by the time
    we have reached the "post finish" time, we use a temporary buffer and
    carry over the value from the other buffer.
    
    However we accidentally only copied the value of the hook variable if
    it already non-nil locally in the temporary buffer (which should not
    be the case) or non-nil globally (which might very well not be the
    case.
    
    Closes #68.
---
 with-editor.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/with-editor.el b/with-editor.el
index a35b6f8..19198da 100644
--- a/with-editor.el
+++ b/with-editor.el
@@ -343,7 +343,7 @@ And some tools that do not handle $EDITOR properly also 
break."
       (with-temp-buffer
         (setq default-directory dir)
         (setq-local with-editor-post-finish-hook post-finish-hook)
-        (when (bound-and-true-p git-commit-post-finish-hook)
+        (when post-commit-hook
           (setq-local git-commit-post-finish-hook post-commit-hook))
         (run-hooks 'with-editor-post-finish-hook)))))