[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/go-mode 498452d 244/495: Don't set old buffer as active af
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/go-mode 498452d 244/495: Don't set old buffer as active after godef--find-file-line-column |
Date: |
Sat, 7 Aug 2021 09:05:24 -0400 (EDT) |
branch: elpa/go-mode
commit 498452d560c07e308e493b7ea7467880dfe56987
Author: Dominik Honnef <dominik@honnef.co>
Commit: Dominik Honnef <dominik@honnef.co>
Don't set old buffer as active after godef--find-file-line-column
godef--find-file-line-column uses find-file to open and switch to a
file, which means the new buffer becomes the current buffer.
Nevertheless, we wrapped it in with-current-buffer, which
would (erroneously) reset the current buffer to the previous one. Only
after all surrounding functions return would current-buffer be correct
again.
This behaviour was confusing and served no purpose, so stop doing it.
Closes gh-85
---
go-mode.el | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/go-mode.el b/go-mode.el
index 2fc8f49..1615d5c 100644
--- a/go-mode.el
+++ b/go-mode.el
@@ -1354,12 +1354,12 @@ visit FILENAME and go to line LINE and column COLUMN."
(let ((filename (match-string 1 specifier))
(line (string-to-number (match-string 2 specifier)))
(column (string-to-number (match-string 3 specifier))))
- (with-current-buffer (funcall (if other-window #'find-file-other-window
#'find-file) filename)
- (go--goto-line line)
- (beginning-of-line)
- (forward-char (1- column))
- (if (buffer-modified-p)
- (message "Buffer is modified, file position might not have been
correct"))))))
+ (funcall (if other-window #'find-file-other-window #'find-file) filename)
+ (go--goto-line line)
+ (beginning-of-line)
+ (forward-char (1- column))
+ (if (buffer-modified-p)
+ (message "Buffer is modified, file position might not have been
correct")))))
(defun godef--call (point)
"Call godef, acquiring definition position and expression
- [nongnu] elpa/go-mode 2f2910c 223/495: fix end-of-defun for function with inline struct/interface arguments, (continued)
- [nongnu] elpa/go-mode 2f2910c 223/495: fix end-of-defun for function with inline struct/interface arguments, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode f1adac0 230/495: switch versioning to semver, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode d9f0bee 232/495: add variable to customize godef command, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 3da268f 285/495: README: improve description of new functions, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 9047fcd 238/495: add a menu, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 466e188 239/495: add `go-play-browse-function', ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 8c13a82 240/495: match identifiers, not type names, when highlighting struct literal, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 775c77a 241/495: immediately store match data in go-unused-imports-lines, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode aaea941 242/495: bump version to 1.2.0, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode bf4a097 243/495: add Iwasaki Yudai to AUTHORS, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 498452d 244/495: Don't set old buffer as active after godef--find-file-line-column,
ELPA Syncer <=
- [nongnu] elpa/go-mode 7041a20 245/495: Bump version to 1.2.1, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode bbaba91 246/495: Add godoc-mode, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 26493e3 264/495: Fix bug in go-goto-function if point is on a non-docstring, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode fa29aea 265/495: go-goto-method-receiver: handle anonymous functions, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 3d801ed 268/495: Ignore anonymous functions if called with prefix, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode c0a3a16 269/495: Update README.md to reflect the latest version of the truth, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode c849d72 273/495: Don't throw errors in some go-goto-* functions, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 37b9f9c 272/495: Change handling of prefix args to consider them booleans, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode c8c6bb0 275/495: go--function-name: return nil for anonymous functions, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode f58910a 276/495: Reimplement go--in-function-p to do as the name says, ELPA Syncer, 2021/08/07