emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] org-pdfview-open doesn't work anymore


From: Nicolas Goaziou
Subject: Re: [O] org-pdfview-open doesn't work anymore
Date: Fri, 05 Feb 2016 18:22:59 +0100

Hello,

Michael Brand <address@hidden> writes:

> +      ;; FIXME: Remove this check when most default installations of
> +      ;; Emacs have at least Org 9.0.
> +      (let ((arglist (help-function-arglist cmd)))
> +     (when (or (memq '&optional arglist)
> +               (memq '&rest arglist)
> +               (/= 2 (length arglist)))
> +       (user-error
> +        (format
> +         "%s%s%S"
> +         "Please see Org News for version 9.0 about `org-file-apps', "
> +         "this function signature is wrong: "
> +         cmd))))

I have the feeling there is some over-engineering involved there. 

In any case, instead of relying on `help-function-arglist', I suggest to
use something lightweight:

(condition-case err
    (funcall ...)
  (wrong-number-of-arguments
   (user-error "Please ..."))
  (invalid-function
   (user-error "Please ...")))


Regards,

-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]