[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] implementing `with' as a list, and respecting `deps' order.
From: |
Kyle Meyer |
Subject: |
Re: [PATCH] implementing `with' as a list, and respecting `deps' order. |
Date: |
Wed, 03 Jun 2020 23:50:40 +0000 |
Mario Frasca writes:
> comments on the html page org-contribute.html:
[...]
> the procedure mentioned there guides me in creating several patch files,
> one per commit. it does not describe the "squashing" you suggested me.
> I'm following your guide, but you might want to review the page yourself.
My suggestion to you in the original thread [*] was in the context of
updating a patch you sent based on reviewer feedback. The instructions
on the org-contribute page are in the context of sending an initial
series to the list, providing a two-patch series as an example. These
are distinct things.
If the change you're proposing conceptually fits into several commits
(of course, how to divide things up is a subjective art), then please do
so. As I said in the original thread:
Just for clarity: In this case, I think the change proposed so far makes
sense to present as a single commit. I'm not claiming that in general a
patch series should be reduced to _one_ commit.
I don't doubt that my descriptions or org-contribute's could be clearer.
Suggestions on how to improve the org-contribute page are of course
welcome, though I think it'd be a mistake to turn it into a Git
tutorial.
[*] https://yhetil.org/orgmode/874krvvdr3.fsf@kyleam.com/