emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] allow for multiline headers


From: Nicolas Goaziou
Subject: Re: [PATCH] allow for multiline headers
Date: Sat, 13 Jun 2020 00:44:14 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hello,

Mario Frasca <mario@anche.no> writes:

> (org-table-to-lisp): simplify code, changing a `while' to a
> `cl-loop', remove leading `hline' symbols from result, edit
> documentation to reflect change.

Please don't. Even if it has its uses, cl-loop is a complicated
non-Lispy beast, and introducing it somewhere is seldom
a simplification.

If you think cl-loop is more efficient in this function, please provide
benchmarks. But I really hope cl-loop (or cl-do, for that matter) is not
going to sprout everywhere.

Also, the first hline is used to determine where to end the header.
A table starting with a hline has no header. Therefore, I suggest to
avoid removing hlines at the beginning of a table, we would lose
information.


Regards,

-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]