emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support f


From: Ihor Radchenko
Subject: Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point)
Date: Sat, 25 May 2024 14:09:31 +0000

Jim Porter <jporterbugs@gmail.com> writes:

>> According to the docstring, functions in `forward-thing-provider-alist'
>> should accept a single argument - the number of "things" to skip
>> forward/backward. But it is not what `org-next-link' expects.
>
> In a twist, it turns out *this* patch for Org-mode was correct, and my 
> prior patch for thingatpt.el was wrong. In short, 'forward-thing' now 
> calls the functions in 'forward-thing-provider-alist' with a BACKWARD 
> flag, rather than an integer N. That's because 'forward-thing' needs to 
> account for the case where you have multiple providers for the same 
> "thing", and so it needs to go one at a time checking all the providers 
> for the best match (read: the one that moves point by the smallest 
> non-zero amount).
>
> I've now pushed the thingatpt fix to the Emacs master branch.

Ok. Now, may you also add NEWS entry?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]