Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

[Ihor Radchenko]

Suhail Singh <suhailsingh247@gmail.com> writes:

>> Please address my concern about :textarea attribute. I do not see why
>> we should ignore it here.
>
> I don't understand your concern.  Could you please elaborate on what you
> mean by "why we should ignore it here"?  What is the "it" and what is
> the "here"?

Your request, in its core, is asking to make treatment of verbatim blocks
more regular in ox-html.

So, if we start allowing arbitrary attributes in more blocks, may as
well include specially handled attributes like :textarea.

As a bonus, it will be possible to factor out common code handling
attributes (including :textarea) into a new internal function that can
then be reused.

>> I am not sure if we want to add all the attributes to every transcoded
>> element. At least in some cases, we do discard them
>> (`org-html--textarea-block').
>
> From the manual:
>
> #+CAPTION: [[info:org#Text areas in HTML export][org#Text areas in HTML 
> export]]
> #+begin_quote
>      The HTML export backend can create such text areas.  It requires an
>   ‘#+ATTR_HTML’ line as shown in the example below with the ‘:textarea’
>   option.  This must be followed by either an example or a source code
>   block.  Other Org block types do not honor the ‘:textarea’ option.
> #+end_quote
>
> The current processing of :textarea does special handling for width and
> height attributes and discards the rest (based on my understanding of
> the code in `org-html--textarea-block').  Said support for :textarea
> attribute exists in `org-html-src-block' and `org-html-example-block'
> which is consistent with the manual.

Yup. But since you are asking to add new features to ox-html, we may as
well do it in full (support all attributes, including special attributes).

> In order to make the code more robust, one may wish to remove :textarea
> from the list of attributes (or issue a user-error or warning if it's
> present) in blocks that were never intended to support it (such as
> `org-html-fixed-width').  I do not have any opinion on this matter.

My opinion here is not to remove :textarea, but to treat it as we do in
other places.

> There is an open question regarding what attributes to support in
> `org-html--textarea-block' (i.e., in the presence of `:textarea'
> option).  I believe the "correct" thing would be to filter out `:width'
> and `:height' (since, if present, they are translated into `rows' and
> `cols' attributes in the generated HTML) and include the rest "as is" in
> the generated HTML

+1

> Regardless of the specifics above regd. :textarea, I believe support for
> #+ATTR_HTML ought to be added for most blocks to allow for CSS class
> and/or inline style to be specified when exporting to HTML.

+1

> Additionally, I consider the absence of such support to be a bug.

Since we do not promise it anywhere, it is not necessarily a bug.
But it would make sense to support setting arbitrary attributes, yes.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>