calc-embedded-activate (bug 2, patch 2)

[Jay Belanger]

This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the address@hidden mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Problem:
When `M-x calc-embedded-activate' (or `M-# a') is run, 
a line like
$ f + g => $
(where the dollar sign is just after the "=> ") will result
in the error
calc-embedded-activate: Wrong type argument: integer-or-marker-p, nil

How to reproduce:
Just call `M-x calc-embedded-active' on a file containing a line like
$ ... => $

My take on it:
`calc-do-embedded-activate' (which is called by
`calc-embedded-activate') searchs for "=> " (among other things),
after which it checks to see if it is looking at the opening of the
formula.  If it is, it tries to go to the end.  The lines that do
this, lines 344-345 in calc-embed.el, are
   (if (looking-at calc-embedded-open-formula)
       (goto-char (match-end 1)))
If calc-embedded-open-formuls finds "$", though, (match-end 1) is
nil, which gives the error.
There doesn't seem to be a reason to check to see if it is looking at
open-formula when it just found part of a formula, and removing the
lines fixes this problem.

Patch:

calc-embed-patch2.gz
Description: calc-embed.el patch (gzipped)

In GNU Emacs 21.3.50.1 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2004-01-28 on vh213602
configured using `configure '--host=i686-pc-linux-gnu' '--prefix=/usr' 
'--libexecdir=/usr/lib' '--mandir=/usr/share/man' '--infodir=/usr/share/info' 
'--with-x' '--with-xpm' '--with-jpeg' '--with-tiff' '--with-gif' '--with-png' 
'--with-x-toolkit=athena' '--with-toolkit-scroll-bars' 'CC=gcc' 
'host_alias=i686-pc-linux-gnu''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Group

Minor modes in effect:
  gnus-topic-mode: t
  gnus-undo-mode: t
  display-time-mode: t
  iswitchb-mode: t
  show-paren-mode: t
  auto-compression-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  column-number-mode: t
  line-number-mode: t

Recent input:
C-x i <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> E m <tab> P r <tab> 1 <tab> 
<return> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <help-echo> <menu-bar> 
<attachments> <attach file...> ~ / E m <tab> c <tab> 
1 <tab> <return> <return> c a l c - e m b e d . e l 
SPC p a t c h SPC ( g z i p p e d ) <return> <return> 
C-c C-c C-x 1 M-x r e p o r t - e m <tab> b <tab> 
<return>

Recent messages:
Scoring...done
Scoring...done
Generating summary...done
Loading emacsbug...done
Parsing /home/belanger/.mailrc... done
Mark set
Sending...
unzipping calc-embed-patch1.gz...done
Sending via mail...
Sending...done