emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

thumbs.el problems


From: Markus Rost
Subject: thumbs.el problems
Date: Wed, 03 Mar 2004 02:06:55 +0100

The following variables in thumbs.el

thumbs-per-line
thumbs-margin
thumbs-thumbsdir-max-size
thumbs-image-resizing-step
thumbs-relief

have numbers as default values, but the custom :type is 'string.
Therefore you can't customize them.  I think the :type should be
changed to 'integer or perhaps, in some cases, to 'number (allowing
floats).  I guess the author of thumbs.el knows best.

Further, what about removing the following part:

===Narrowed Buffer thumbs.el================================
;; Abort if in-line imaging isn't supported (i.e. Emacs-20.7)

(when (not (display-images-p))
  (error "Your Emacs version (%S) doesn't support in-line images,
was not compiled with image support or is run in console mode.  
Upgrade to Emacs 21.1 or newer, compile it with image support 
or use a window-system"  
         emacs-version))
============================================================

Other lisp libraries related with images, like image.el, don't have
such an abort feature, and it is perhaps best to have it nowhere.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]